Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

Add TOC to Ruby version module #1388

Merged
merged 3 commits into from
Jun 29, 2017
Merged

Add TOC to Ruby version module #1388

merged 3 commits into from
Jun 29, 2017

Conversation

evaogbe
Copy link
Contributor

@evaogbe evaogbe commented Jun 26, 2017

No description provided.

@evaogbe evaogbe requested review from landrito and geigerj June 26, 2017 20:25
geigerj
geigerj reviewed Jun 26, 2017
View reviewed changes
src/test/java/com/google/api/codegen/testdata/ruby_doc_version_index_library.baseline Outdated
#
# | Filename | Description |
# | -------- | ----------- |
# | library/v1/library_service_client | Accesses the Library::V1::LibraryServiceClient |

This comment was marked as spam.

Sign in to view

@codecov-io
Copy link

codecov-io commented Jun 26, 2017 •
edited
Loading

Codecov Report

Merging #1388 into master will decrease coverage by 0.01%.
The diff coverage is 98.03%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1388      +/-   ##
============================================
- Coverage     86.55%   86.54%   -0.02%     
- Complexity     3949     3954       +5     
============================================
  Files           384      386       +2     
  Lines         15868    15904      +36     
  Branches       1757     1758       +1     
============================================
+ Hits          13735    13764      +29     
- Misses         1663     1669       +6     
- Partials        470      471       +1
Impacted Files Coverage Δ Complexity Δ
...api/codegen/viewmodel/metadata/TocContentView.java 100% <100%> (ø) 2 <2> (?)
.../api/codegen/viewmodel/metadata/TocModuleView.java 100% <100%> (ø) 3 <3> (?)
...ansformer/ruby/RubyPackageMetadataTransformer.java 95.55% <100%> (+0.39%) 22 <3> (+3) ⬆️
.../transformer/ruby/RubyGapicSurfaceTransformer.java 98.42% <96.77%> (-1.58%) 12 <0> (ø)
...i/codegen/viewmodel/metadata/SimpleModuleView.java 0% <0%> (-100%) 0% <0%> (-3%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c626ab0...9afeaa4. Read the comment docs.

@evaogbe
Copy link
Contributor Author

evaogbe commented Jun 29, 2017

@landrito LGTY?

@evaogbe evaogbe merged commit 7c3ff74 into googleapis:master Jun 29, 2017
@evaogbe evaogbe deleted the ruby-toc3 branch June 29, 2017 21:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@landrito landrito landrito approved these changes

@geigerj geigerj geigerj approved these changes

Assignees

@landrito landrito

@geigerj geigerj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@evaogbe @codecov-io @landrito @geigerj